lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nicholas Knize (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7094) spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy numeric encoding
Date Mon, 28 Mar 2016 17:42:26 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214530#comment-15214530
] 

Nicholas Knize commented on LUCENE-7094:
----------------------------------------

bq. I'm unable to reproduce the issue with UninvertingReader you spoke of.

That's because you added back {{UninvertingReader}}. The intent was to completely cut the
tests over to docvalues and remove test complexity with {{UninvertingReader}}. I'm fine discussing
that in a separate issue and leaving in UIR for now. I don't want this further delaying the
release.

bq. Let me know if you'd like to use Reviewboard;

I have no problem using Reviewboard. While I think there's some more clean up to do in these
Strategies I think we've achieved the main objective for this issue with re: to the 6.0 release
(cut over to Point values and deprecate LegacyNumerics)?

Do you have any issues with me committing this and performing code/test cleanup in 6.x?

> spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy numeric
encoding
> ----------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7094
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7094
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Nicholas Knize
>         Attachments: LUCENE-7094.patch, LUCENE-7094.patch, LUCENE_7094.patch
>
>
> We need to deprecate these since they work on the old encoding and provide points based
alternatives.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message