lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7094) spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy numeric encoding
Date Mon, 28 Mar 2016 18:06:26 GMT


David Smiley commented on LUCENE-7094:

bq. That's because you added back UninvertingReader. The intent was to completely cut the
tests over to docvalues and remove test complexity with UninvertingReader. I'm fine discussing
that in a separate issue and leaving in UIR for now. I don't want this further delaying the

For now i'd rather continue to test that UninvertingReader works; particularly since we can
feel better about the upgrade path.  In some separate issue we can remove it if you feel it
isn't warranted (there is some complexity in testing it, sure).

bq. Do you have any issues with me committing this and performing code/test cleanup in 6.x?

Sort of... I'd rather we not commit something that should be cleaned up unless it's like way
too complex to do at once.  That's pretty normal.  I get the sense that you feel we're in
a hurry, and I have time today to help.  What do you think of my patch, particularly to PointVectorStrategy?
 I'm willing to immediately get on doing the same approach to BBoxStrategy; it won't take
long.  FWIW I'm on #lucene-dev IRC to expedite any communication.

> spatial-extras BBoxStrategy and (confusingly!) PointVectorStrategy use legacy numeric
> ----------------------------------------------------------------------------------------------
>                 Key: LUCENE-7094
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Nicholas Knize
>         Attachments: LUCENE-7094.patch, LUCENE-7094.patch, LUCENE_7094.patch
> We need to deprecate these since they work on the old encoding and provide points based

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message