lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Assigned] (SOLR-8864) TestTestInjection needs to cleanup after itself -- causes TestCloudDeleteByQuery fail (may be symptom of larger problem?)
Date Thu, 17 Mar 2016 00:42:33 GMT

     [ https://issues.apache.org/jira/browse/SOLR-8864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mark Miller reassigned SOLR-8864:
---------------------------------

    Assignee: Mark Miller

> TestTestInjection needs to cleanup after itself -- causes TestCloudDeleteByQuery fail
(may be symptom of larger problem?)
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8864
>                 URL: https://issues.apache.org/jira/browse/SOLR-8864
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Mark Miller
>         Attachments: jenkins.log
>
>
> https://builds.apache.org/job/Lucene-Solr-Tests-6.x/65/ recently reported a failure from
TestCloudDeleteByQuery's init methods that made no sense to me -- looking at the logs showed
an error from "TestInjection.parseValue" even though this test doesn't do anything to setup
TestInjection...
> {noformat}
>    [junit4]   2> 527801 ERROR (qtp1490160324-5239) [n:127.0.0.1:48763_solr c:test_col
s:shard1 r:core_node4 x:test_col_shard1_replica2] o.a.s.h.RequestHandlerBase java.lang.RuntimeException:
No match, probably bad syntax: TRUE:0:
>    [junit4]   2> 	at org.apache.solr.util.TestInjection.parseValue(TestInjection.java:236)
>    [junit4]   2> 	at org.apache.solr.util.TestInjection.injectFailReplicaRequests(TestInjection.java:159)
>    [junit4]   2> 	at org.apache.solr.update.processor.DistributedUpdateProcessor.setupRequest(DistributedUpdateProcessor.java:356)
> {noformat}
> ...the immediate problem seems to be that TestTestInjection doesn't do anything to cleanup
after itself (it never calls {{TestInjection.reset()}}, and doesn't subclass SolrTestCaseJ4)
but i'm surprised this hasn't caused a lot more weird failures since this test was added back
in december -- i wonder if this this "bad syntax" RuntimeException, when injected into the
distributed updates, isn't causing a problem in most cases because of leader initiated recovery,
but maybe something specific about the codepaths used in TestCloudDeleteByQuery (which is
only a few weeks old) don't work.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message