lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-8866) UpdateLog should throw an exception when serializing unknown types
Date Mon, 21 Mar 2016 00:43:34 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203591#comment-15203591
] 

ASF subversion and git services commented on SOLR-8866:
-------------------------------------------------------

Commit a22099a3986de1f36f926b4e106827c5308708b0 in lucene-solr's branch refs/heads/jira/SOLR-445
from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a22099a ]

SOLR-8866: UpdateLog now throws an error if it can't serialize a field value


> UpdateLog should throw an exception when serializing unknown types
> ------------------------------------------------------------------
>
>                 Key: SOLR-8866
>                 URL: https://issues.apache.org/jira/browse/SOLR-8866
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 6.1
>
>         Attachments: SOLR_8866_UpdateLog_show_throw_for_unknown_types.patch
>
>
> When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize,
nor does it implement the {{ObjectResolver}} interface, it currently serializes the object
as the classname, colon, then toString() of the object.
> This may appear innocent but _not_ throwing an exception hides bugs.  One example is
that the UpdateLog, which uses JavaBinCodec, to save a document.  The result is that this
bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and
then this value pretends to be a suitable value to the final document in the leader.  But
of course it isn't.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message