lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Chanan (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LUCENE-7115) Speed up FieldCache.CacheEntry toString by setting initial StringBuilder capacity
Date Mon, 21 Mar 2016 18:56:25 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gregory Chanan resolved LUCENE-7115.
------------------------------------
       Resolution: Fixed
    Fix Version/s: 6.1
                   trunk

Thanks for the review, Mark, committed to trunk and 6.1

> Speed up FieldCache.CacheEntry toString by setting initial StringBuilder capacity
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-7115
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7115
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: trunk, 6.1
>
>         Attachments: LUCENE-7115.patch
>
>
> Solr can end up printing a lot of these objects via the JmxMonitoriedMap, see SOLR-8869
and SOLR-6747 as examples.
> From looking at some profiles, a lot of time and memory are spent resizing the StringBuilder,
which doesn't set the initial capacity.
> On my cluster, the strings are a bit over 200 chars; I set the initial capacity to 250
and ran tests calling toString 1000 times.  Tests consistently show 10-15% improvement when
setting the initial capacity.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message