lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Ernst (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7118) Remove multidimensional arrays from PointRangeQuery
Date Sun, 20 Mar 2016 20:25:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203500#comment-15203500
] 

Ryan Ernst commented on LUCENE-7118:
------------------------------------

Shouldn't this line in PointRangeQuery:

{quote}
+    if (upperPoint.length != upperPoint.length) {
{quote}

Be checking {{lowerPoint.length != upperPoint.length}}?

> Remove multidimensional arrays from PointRangeQuery
> ---------------------------------------------------
>
>                 Key: LUCENE-7118
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7118
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7118.patch
>
>
> This use of byte[][] has caused two bugs: LUCENE-7085 and LUCENE-7117.
> It is not necessary, and causes code duplication in most Point classes because they have
to have a {{pack()}} that encodes to byte[] for the indexer but a {{encode()}} or similar
that makes multi-D byte[][] for just this query.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message