lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-8873) Enforce dataDir/instanceDir/ulogDir to be paths that contain only a controlled subset of characters
Date Fri, 25 Mar 2016 21:47:25 GMT

    [ https://issues.apache.org/jira/browse/SOLR-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212460#comment-15212460
] 

Tomás Fernández Löbbe commented on SOLR-8873:
---------------------------------------------

Any thoughts on this? I'm pretty sure someone must think this is wrong/useless or that the
pattern should be changed, I'd like to hear their opinions. Otherwise I'll just go ahead with
this patch.
One thought is that I could also leave the door open for changing the pattern if someone needs
it (for example, by a system property) in case this really breaks someone's use case.

> Enforce dataDir/instanceDir/ulogDir to be paths that contain only a controlled subset
of characters
> ---------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8873
>                 URL: https://issues.apache.org/jira/browse/SOLR-8873
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomás Fernández Löbbe
>         Attachments: SOLR-8873.patch
>
>
> We currently support any valid path for dataDir/instanceDir/ulogDir. I think we should
prevent special characters and restrict to a subset that is commonly used and tested.
> My initial proposals it to allow the Java pattern: {code:java}"^[a-zA-Z0-9\\.\\ \\\\\\-_/\"':]+$"{code}
but I'm open to suggestions. I'm not sure if there can be issues with HDFS paths (this pattern
does pass the tests we currently have), or some other use case I'm not considering.
> I also think our tests should use all those characters randomly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message