lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7120) Improve BKDWriter's checksum verification
Date Mon, 21 Mar 2016 09:49:25 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203954#comment-15203954
] 

ASF subversion and git services commented on LUCENE-7120:
---------------------------------------------------------

Commit 0e189bca2d2af8bbf3dacaa27212dc9824a3b845 in lucene-solr's branch refs/heads/master
from Mike McCandless
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0e189bc ]

LUCENE-7120: re-use readers while recursing in BKDWriter so we get more thorough checksum
verification on its temp files


> Improve BKDWriter's checksum verification
> -----------------------------------------
>
>                 Key: LUCENE-7120
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7120
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master, 6.1
>
>         Attachments: LUCENE-7120.patch
>
>
> The checksum verification only works when {{BKDWriter}} fully reads one of its temp files,
but today it opens a reader, seeks to one slice, reads that, and closes.
> But it turns out, on the full recursion from any given node in the tree, a given file
is read once, fully, so if we just share the readers, then we can get checksum verification
for these files as well.
> This is a non-trivial change ... I don't plan on pushing it for 6.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message