lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Updated] (LUCENE-7120) Improve BKDWriter's checksum verification
Date Sat, 19 Mar 2016 15:00:36 GMT


Michael McCandless updated LUCENE-7120:
    Attachment: LUCENE-7120.patch

Relatively simple patch, adding a new {{getSharedReader}} method to {{PointWriter}}, so that
the sharing is explicit as we recurse.

We still eagerly close the shared readers.

> Improve BKDWriter's checksum verification
> -----------------------------------------
>                 Key: LUCENE-7120
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: master, 6.1
>         Attachments: LUCENE-7120.patch
> The checksum verification only works when {{BKDWriter}} fully reads one of its temp files,
but today it opens a reader, seeks to one slice, reads that, and closes.
> But it turns out, on the full recursion from any given node in the tree, a given file
is read once, fully, so if we just share the readers, then we can get checksum verification
for these files as well.
> This is a non-trivial change ... I don't plan on pushing it for 6.0.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message