lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7123) deduplicate/cleanup spatial distance
Date Mon, 21 Mar 2016 12:32:25 GMT


Robert Muir commented on LUCENE-7123:

I'm rejecting lucene.internal/lucene.experimental. I helped add the mechanism but I regret
it: I think its a cop-out. Instead the problem is too much shit being made public without
any thought to the API. I am going to clean this stuff up, it is just going to take time.

> deduplicate/cleanup spatial distance
> ------------------------------------
>                 Key: LUCENE-7123
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7123.patch, LUCENE-7123.patch
> Currently there is a bit of a mess here: SloppyMath.haversin is slightly different from
GeoDistanceUtils.haversin, the latter is actually slightly faster and uses a simple fixed
earth diameter (which makes calculations easier too).
> But one of these returns meters, the other kilometers. Furthermore lucene/spatial now
uses some sin/tan functions that were added to sloppymath with some accuracy guarantees (which
are untested, and not quite correct). Lucene/spatial queries also inconsistently mix the two
different functions together for various purposes and this just causes headaches. Its tests
did this recently too.
> We need to clean this up, otherwise users will be confused. E.G. they will see different
results from expressions than from queries and not understand.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message