lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7123) deduplicate/cleanup spatial distance
Date Mon, 21 Mar 2016 13:54:25 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204207#comment-15204207
] 

Michael McCandless commented on LUCENE-7123:
--------------------------------------------

bq. I'm rejecting lucene.internal/lucene.experimental.

OK :)

> deduplicate/cleanup spatial distance
> ------------------------------------
>
>                 Key: LUCENE-7123
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7123
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-7123.patch, LUCENE-7123.patch
>
>
> Currently there is a bit of a mess here: SloppyMath.haversin is slightly different from
GeoDistanceUtils.haversin, the latter is actually slightly faster and uses a simple fixed
earth diameter (which makes calculations easier too).
> But one of these returns meters, the other kilometers. Furthermore lucene/spatial now
uses some sin/tan functions that were added to sloppymath with some accuracy guarantees (which
are untested, and not quite correct). Lucene/spatial queries also inconsistently mix the two
different functions together for various purposes and this just causes headaches. Its tests
did this recently too.
> We need to clean this up, otherwise users will be confused. E.G. they will see different
results from expressions than from queries and not understand.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message