lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (LUCENE-7123) deduplicate/cleanup spatial distance
Date Mon, 21 Mar 2016 15:53:25 GMT


ASF subversion and git services commented on LUCENE-7123:

Commit c49e761c1bac84efa1e92a6a7b0f2169bba2612a in lucene-solr's branch refs/heads/branch_6_0
from [~rcmuir]
[;h=c49e761 ]

LUCENE-7123: deduplicate/cleanup spatial distance

> deduplicate/cleanup spatial distance
> ------------------------------------
>                 Key: LUCENE-7123
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: master, 6.0
>         Attachments: LUCENE-7123.patch, LUCENE-7123.patch
> Currently there is a bit of a mess here: SloppyMath.haversin is slightly different from
GeoDistanceUtils.haversin, the latter is actually slightly faster and uses a simple fixed
earth diameter (which makes calculations easier too).
> But one of these returns meters, the other kilometers. Furthermore lucene/spatial now
uses some sin/tan functions that were added to sloppymath with some accuracy guarantees (which
are untested, and not quite correct). Lucene/spatial queries also inconsistently mix the two
different functions together for various purposes and this just causes headaches. Its tests
did this recently too.
> We need to clean this up, otherwise users will be confused. E.G. they will see different
results from expressions than from queries and not understand.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message