lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7145) We need only one set of polygon util methods
Date Mon, 28 Mar 2016 18:14:25 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214603#comment-15214603
] 

ASF subversion and git services commented on LUCENE-7145:
---------------------------------------------------------

Commit 8c5115ea9a6a158578959860b4163e94c9e2ed62 in lucene-solr's branch refs/heads/master
from [~rcmuir]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8c5115e ]

LUCENE-7145: consolidate polygon range checks, tests, box usage. make cannot -> must not
consistent so we can test this stuff.


> We need only one set of polygon util methods
> --------------------------------------------
>
>                 Key: LUCENE-7145
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7145
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> LatLonPoint methods are calling {{*precise()}} methods such as rectCrossesPolyPrecise().
GeoPointMethods are calling {{*approx()}} methods such as rectCrossesPolyApprox().
> I don't understand why we have two versions of these methods, why one is approximate,
why we would ever use that, etc.
> These geo methods are extremely expensive: we can't afford two copies. For example, in
the case of these polygon methods, they are still missing direct tests. We need to remove
one copy of these. I propose to remove the approx ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message