lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-7162) geo random tests still have reproducibility issues
Date Fri, 01 Apr 2016 14:17:25 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-7162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Robert Muir updated LUCENE-7162:
--------------------------------
    Attachment: mychanges.patch

Attached is my local mods. I've run this twice from lucene/sandbox:

{noformat}
ant beast -Dtestcase=TestLatLonPointQueries -Dbeast.iters=100 -Dtests.nightly=true -Dtests.multiplier=3
{noformat}

nightly/multiplier is unfortunately currently necessary to hit the edge case where it fails.

The first fail did not reproduce:
{noformat}
  [beaster] Started J0 PID(11125@localhost).
  [beaster]   2> NOTE: reproduce with: ant test  -Dtestcase=TestLatLonPointQueries -Dtests.method=testAllLonEqual
-Dtests.seed=1F5C474CF302EFAC -Dtests.multiplier=3 -Dtests.nightly=true -Dtests.locale=sr-Latn
-Dtests.timezone=Pacific/Noumea -Dtests.asserts=true -Dtests.file.encoding=UTF-8
  [beaster] [10:07:58.055] FAILURE 2.24s | TestLatLonPointQueries.testAllLonEqual <<<
  [beaster]    > Throwable #1: java.lang.AssertionError: wrong hit (first of possibly more):
  [beaster]    > 
  [beaster]    > FAIL: id=61115 should not match but did
  [beaster]    >   query=ConstantScore(point:[79.38078825362027 TO 79.46481658145785],[-180.0
TO -118.28774940222502] point:[79.38078825362027 TO 79.46481658145785],[-118.21577919647098
TO 179.99999991618097]) docID=44901
  [beaster]    >   lat=79.38078825362027 lon=-117.36744618974626
  [beaster]    >   deleted?=false
  [beaster]    > 	at __randomizedtesting.SeedInfo.seed([1F5C474CF302EFAC:8E56B6B103A8AFB8]:0)
  [beaster]    > 	at org.junit.Assert.fail(Assert.java:93)
  [beaster]    > 	at org.apache.lucene.spatial.util.BaseGeoPointTestCase.verifyRandomRectangles(BaseGeoPointTestCase.java:875)
{noformat}

When i plug in the seed:
{noformat}
rmuir@beast:~/workspace/lucene-solr/lucene/sandbox$ ant test  -Dtestcase=TestLatLonPointQueries
-Dtests.method=testAllLonEqual -Dtests.seed=1F5C474CF302EFAC -Dtests.multiplier=3 -Dtests.nightly=true
-Dtests.locale=sr-Latn -Dtests.timezone=Pacific/Noumea -Dtests.asserts=true -Dtests.file.encoding=UTF-8
...
-test:
[junit4:pickseed] Seed property 'tests.seed' already defined: 1F5C474CF302EFAC
   [junit4] <JUnit4> says salut! Master seed: 1F5C474CF302EFAC
   [junit4] Executing 1 suite with 1 JVM.
   [junit4] 
   [junit4] Started J0 PID(11341@localhost).
   [junit4] Suite: org.apache.lucene.search.TestLatLonPointQueries
   [junit4] OK      9.41s | TestLatLonPointQueries.testAllLonEqual
   [junit4] Completed [1/1] in 9.77s, 1 test
   [junit4] 
   [junit4] JVM J0:     0.37 ..    10.73 =    10.36s
   [junit4] Execution time total: 10 seconds
{noformat}

I run it again and it fails in a different test method (but doing a similar check), and this
time that seed reproduces:
{noformat}
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestLatLonPointQueries -Dtests.method=testRandomMedium
-Dtests.seed=12FD8A8C25EDC679 -Dtests.multiplier=3 -Dtests.nightly=true -Dtests.locale=zh
-Dtests.timezone=CST6CDT -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
...
[junit4:pickseed] Seed property 'tests.seed' already defined: 12FD8A8C25EDC679
   [junit4] <JUnit4> says g'day! Master seed: 12FD8A8C25EDC679
   [junit4] Executing 1 suite with 1 JVM.
   [junit4] 
   [junit4] Started J0 PID(11833@localhost).
   [junit4] Suite: org.apache.lucene.search.TestLatLonPointQueries
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestLatLonPointQueries -Dtests.method=testRandomMedium
-Dtests.seed=12FD8A8C25EDC679 -Dtests.multiplier=3 -Dtests.nightly=true -Dtests.locale=zh
-Dtests.timezone=CST6CDT -Dtests.asserts=true -Dtests.file.encoding=US-ASCII
   [junit4] FAILURE 3.46s | TestLatLonPointQueries.testRandomMedium <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: wrong hit (first of possibly more):
   [junit4]    > FAIL: id=24597 should not match but did
   [junit4]    >   box=GeoRect(lon=119.33025300632073 TO 119.15591075792199 (crosses dateline!)
lat=21.357182089731893 TO 21.579851393460306)
   [junit4]    >   query=ConstantScore(point:[21.357182068750262 TO 21.579851391725242],[-180.0
TO 119.15591072291136] point:[21.357182068750262 TO 21.579851391725242],[119.33025296777487
TO 179.99999991618097]) docID=41118
   [junit4]    >   lat=21.357182068750262 lon=118.96621911786497
   [junit4]    >   deleted?=false
{noformat}


> geo random tests still have reproducibility issues
> --------------------------------------------------
>
>                 Key: LUCENE-7162
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7162
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: mychanges.patch
>
>
> I am trying to remove some tricky test leniency/fix rounding issues in our geo fields,
but it is frustrating when failures don't always reproduce.
> Often they now do, but sometimes they still do not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message