lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Created] (SOLR-8946) bin/post script stdin detection is faulty
Date Tue, 05 Apr 2016 17:41:25 GMT
David Smiley created SOLR-8946:
----------------------------------

             Summary: bin/post script stdin detection is faulty
                 Key: SOLR-8946
                 URL: https://issues.apache.org/jira/browse/SOLR-8946
             Project: Solr
          Issue Type: Bug
          Components: SimplePostTool
    Affects Versions: 6.0
         Environment: Ubuntu
            Reporter: David Smiley


Summary:  I think the {{post}} bash script tries to detect stdin the wrong way.

If I run "post -h" I see some examples, to include this:
{code}
echo '{commit: {}}' | bin/post -c my_collection -type application/json -out yes -d
{code}
However if I try it, Solr returns this error: {{Cannot parse provided JSON: JSON Parse Error:
char=<,position=0 BEFORE='<' AFTER='add/>'}}

I see that {{post}} is sending an {{<add />}} in certain cases, but it's not supposed
to when the mode is stdin.  Looking closer, it appears to be because of this line:
{{if [[ -s /dev/stdin ]]; then}}
If I change it to this (which I figured out after googling around; I'm no bash expert!):
{{if [[ ! -t 0 ]]; then}}
Apparently '0' represents stdin.  It works for me.  [~thelabdude] might you take a look? 
I'd be happy to add a formal patch & commit for this trivial change but it really needs
other eyes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message