lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Updated] (SOLR-9028) fix bugs in (add sanity checks for) SSL clientAuth testing
Date Thu, 28 Apr 2016 03:18:12 GMT


Hoss Man updated SOLR-9028:
    Attachment: SOLR-9028.patch

Updated patch...

bq. I want to cleanup some of the SSLTestConfig methods that only exist in master and have
weird side effects (introduced in SOLR-4509)


bq. I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation
to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more.

I decided this is probably not a good idea -- no reason to add to the number of things SolrTestCaseJ4
is doing automagically w/o a need for it.


I think this is basically ready ... I'm going to hammer on tests w/it for a bit.

> fix bugs in (add sanity checks for) SSL clientAuth testing
> ----------------------------------------------------------
>                 Key: SOLR-9028
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch,
SOLR-9028.patch, SOLR-9028.patch, os.x.failure.txt
> While looking into SOLR-8970 i realized there was a whole heap of problems with how clientAuth
was being handled in tests.  Notably: it wasn't actaully being used when the randomization
selects it (aparently due to a copy/paste mistake in SOLR-7166).  But there are few other
misc issues (improper usage of sysprops overrides for tests, missuage of keystore/truststore
in test clients, etc..)
> I'm working up a patch to fix all of this, and add some much needed tests to *explicitly*
verify both SSL and clientAuth that will include some "false positive" verifications, and
some "test the test" checks.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message