lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5944) Support updates of numeric DocValues
Date Thu, 26 May 2016 12:07:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301985#comment-15301985
] 

Ishan Chattopadhyaya commented on SOLR-5944:
--------------------------------------------

bq. (I'm pretty sure) I was able to reproduce the root cause of the randomized failures in
LUCENE-7301.
Thanks Hoss for beating me to it!

{quote}
testReplay5 - still uses "inc" for doc id=0, but uses "set" for every other doc in the index

    this currently fails with an NPE in AtomicUpdateDocumentMerger.doInPlaceUpdateMerge(AtomicUpdateDocumentMerger.java:283)
{quote}
I think the problem there is that a "set" operation was attempted at a document that still
doesn't exist in the index. I think such an operation works with atomic updates, but the underlying
docValues API doesn't support updates of dv fields that don't exist yet. I will try to handle
this better, instead of throwing NPE.

I shall work on fixing your review comments regarding the tests, and increase their scope
as you suggest. My idea behind the tests were (and naming could be improved): TestInPlaceUpdate
just tests some basic cases in non-cloud mode, TestStressInPlaceUpdates tests lots of documents,
lots of updates, lots of threads and cloud mode, InPlaceUpdateDistribTest for some basic operations/scenarios
in cloud (including testing if same document was updated, or a new one was created). I was
thinking that if we can get past the DV updates flushing issue (LUCENE-7301), we can focus
well on improving scope of tests more. Thanks for your review!

> Support updates of numeric DocValues
> ------------------------------------
>
>                 Key: SOLR-5944
>                 URL: https://issues.apache.org/jira/browse/SOLR-5944
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Shalin Shekhar Mangar
>         Attachments: DUP.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch,
SOLR-5944.patch, TestStressInPlaceUpdates.eb044ac71.beast-167-failure.stdout.txt, TestStressInPlaceUpdates.eb044ac71.beast-587-failure.stdout.txt,
TestStressInPlaceUpdates.eb044ac71.failures.tar.gz, hoss.62D328FA1DEA57FD.fail.txt, hoss.62D328FA1DEA57FD.fail2.txt,
hoss.62D328FA1DEA57FD.fail3.txt, hoss.D768DD9443A98DC.fail.txt, hoss.D768DD9443A98DC.pass.txt
>
>
> LUCENE-5189 introduced support for updates to numeric docvalues. It would be really nice
to have Solr support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message