lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9028) fix bugs in (add sanity checks for) SSL clientAuth testing
Date Sun, 01 May 2016 05:35:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265617#comment-15265617
] 

ASF subversion and git services commented on SOLR-9028:
-------------------------------------------------------

Commit 8e8f6c1fa8b40dc6a7385551a79fdcdd240f5427 in lucene-solr's branch refs/heads/branch_6x
from [~hossman_lucene@fucit.org]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8e8f6c1 ]

SOLR-9028: Fix 2 SSL test related bugs...

1) SolrTestCaseJ4 should always reset the HttpClientConfigurer in afterClass, regardless of
wether ssl was used
   (when SSL is not used, the active configurer explicitly excludes SSL)
2) HttpClientUtilTest.testSSLSystemProperties made no sense as written.  setSSLSystemProperties()
didn't have any
   effect on what was being tested, even if it was useful it would only have affected what
keystore/truststore were
   used, not wether HTTPS was supported or not.


> fix bugs in (add sanity checks for) SSL clientAuth testing
> ----------------------------------------------------------
>
>                 Key: SOLR-9028
>                 URL: https://issues.apache.org/jira/browse/SOLR-9028
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch,
SOLR-9028.patch, SOLR-9028.patch, os.x.failure.txt
>
>
> While looking into SOLR-8970 i realized there was a whole heap of problems with how clientAuth
was being handled in tests.  Notably: it wasn't actaully being used when the randomization
selects it (aparently due to a copy/paste mistake in SOLR-7166).  But there are few other
misc issues (improper usage of sysprops overrides for tests, missuage of keystore/truststore
in test clients, etc..)
> I'm working up a patch to fix all of this, and add some much needed tests to *explicitly*
verify both SSL and clientAuth that will include some "false positive" verifications, and
some "test the test" checks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message