lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9065) Migrate solrj tests from AbstractDistribZkTestBase to SolrCloudTestCase
Date Thu, 05 May 2016 18:11:12 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272752#comment-15272752
] 

Mark Miller commented on SOLR-9065:
-----------------------------------

We have a commit then review policy and generally favor forward progress.

I appreciate that Alan's work here has caused some concern around other work and 6.1. So what?
Alan's work was fine and had multiple eyes on it. Now there are more eyes and Alan will be
open to working with them as he always is.

If one of the tests that was converted needs to be un-converted or briefly un-converted, so
what? Perhaps there are other short term options as well. It's a large code base and many
issues cross a lot of code. We will step on each other's toes, it's part of the game.

> Migrate solrj tests from AbstractDistribZkTestBase to SolrCloudTestCase
> -----------------------------------------------------------------------
>
>                 Key: SOLR-9065
>                 URL: https://issues.apache.org/jira/browse/SOLR-9065
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 6.1, master
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-9065.patch
>
>
> AbstractDistribZkTestBase sets up collections using the legacy core-based system, and
does a lot of comparing things against control collections that the SolrJ tests really don't
require.  We should migrate these tests to using SolrCloudTestCase instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message