lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9065) Migrate solrj tests from AbstractDistribZkTestBase to SolrCloudTestCase
Date Thu, 05 May 2016 20:09:13 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15272968#comment-15272968
] 

Mark Miller commented on SOLR-9065:
-----------------------------------

bq. just a "shout out" 

Following the mailing list. We are not a commit then review project. The result that happened
is how this should work. Then 9 out of 10 times we move fast, and once we make an adjustment
to the commit.

Everyone just needs to relax. No one owns any area of the code, no one has to be checked with
before changes. It's on anyone who cares to follow email and JIRA. This did not appear to
be a controversial change, a patch went up, hossman +1'd.

This is how it's all supposed to work.

> Migrate solrj tests from AbstractDistribZkTestBase to SolrCloudTestCase
> -----------------------------------------------------------------------
>
>                 Key: SOLR-9065
>                 URL: https://issues.apache.org/jira/browse/SOLR-9065
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 6.1, master
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-9065.patch
>
>
> AbstractDistribZkTestBase sets up collections using the legacy core-based system, and
does a lot of comparing things against control collections that the SolrJ tests really don't
require.  We should migrate these tests to using SolrCloudTestCase instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message