lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7283) Move SlowCompositeReaderWrapper to solr sources
Date Sat, 14 May 2016 13:19:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15283554#comment-15283554
] 

David Smiley commented on LUCENE-7283:
--------------------------------------

Sure, +1. It's a simple class any way. 

> Move SlowCompositeReaderWrapper to solr sources
> -----------------------------------------------
>
>                 Key: LUCENE-7283
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7283
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>
> Spinoff from LUCENE-6766, where we fixed index-time sorting to have first class support
in Lucene's ore, and no longer use {{SlowCompositeReaderWrapper}}.
> This is a dangerous, long living class, that tries to pretend a set of N segments is
actually just a single segment.  It's a leaky abstraction, has poor performance, and puts
undue pressure on the APIs of new Lucene features to try to keep up this illusion.
> With LUCENE-6766, finally all usage of this class (except for {{UninvertedReader}} tests,
which should maybe also move out?) has been removed from Lucene, so I think we should move
it to Solr.  This may also lead to a solution for LUCENE-7086 since e.g. the class could tap
into solr's schema to "know" how to handle points fields properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message