lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-9161) SolrPluginUtils.invokeSetters should accommodate setter variants
Date Wed, 08 Jun 2016 10:32:21 GMT

     [ https://issues.apache.org/jira/browse/SOLR-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Christine Poerschke updated SOLR-9161:
--------------------------------------
    Attachment: SOLR-9161.patch

Unable to reproduce the test failure locally (with that seed).

Attaching alternative patch using the java.beans.Introspector class as Uwe suggested, the
tests pass locally for me (but then they also did so with the original patch).

Steve, Uwe - when you have a spare moment, would you mind applying/running the test locally
to you? If all is well I'd be aiming to commit the change sometime next week.

> SolrPluginUtils.invokeSetters should accommodate setter variants
> ----------------------------------------------------------------
>
>                 Key: SOLR-9161
>                 URL: https://issues.apache.org/jira/browse/SOLR-9161
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9161.patch, SOLR-9161.patch
>
>
> The code currently assumes that there is only one setter (or if there are several setters
then the first one found is used and it could mismatch on the arg type).
> Context and motivation is that a class with a
> {code}
> void setAFloat(float val) {
>   this.val = val;
> }
> {code}
> setter may wish to also provide a
> {code}
> void setAFloat(String val) {
>   this.val = Float.parseFloat(val);
> }
> {code}
> convenience setter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message