lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9161) SolrPluginUtils.invokeSetters should accommodate setter variants
Date Wed, 08 Jun 2016 18:48:20 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15321190#comment-15321190
] 

Steve Rowe commented on SOLR-9161:
----------------------------------

Christine, I went back and, using Miller's beasting script, beasted {{SolrPluginUtilsTest}}
for 100 iterations on the revision just before Hoss reverted, and it failed 72/100 iterations.
 My seed above also failed for me at that revision.

I then applied your latest patch to current master and again beasted 100 iterations of {{SolrPluginUtilsTest}},
and it failed 0/100 iterations.  (My reported seed also did not fail, but I'm not sure whether
that's useful information.)

> SolrPluginUtils.invokeSetters should accommodate setter variants
> ----------------------------------------------------------------
>
>                 Key: SOLR-9161
>                 URL: https://issues.apache.org/jira/browse/SOLR-9161
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9161.patch, SOLR-9161.patch
>
>
> The code currently assumes that there is only one setter (or if there are several setters
then the first one found is used and it could mismatch on the arg type).
> Context and motivation is that a class with a
> {code}
> void setAFloat(float val) {
>   this.val = val;
> }
> {code}
> setter may wish to also provide a
> {code}
> void setAFloat(String val) {
>   this.val = Float.parseFloat(val);
> }
> {code}
> convenience setter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message