lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9161) SolrPluginUtils.invokeSetters should accommodate setter variants
Date Wed, 01 Jun 2016 17:02:59 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310648#comment-15310648
] 

Hoss Man commented on SOLR-9161:
--------------------------------

Since these test failures were so reliablly reproducing, and happening on so many seeds, and
this change didn't seem to be a dependency for any other existing functionality on master,
i went ahead and reverted until Christine can have a chance to dig into the failures more.

> SolrPluginUtils.invokeSetters should accommodate setter variants
> ----------------------------------------------------------------
>
>                 Key: SOLR-9161
>                 URL: https://issues.apache.org/jira/browse/SOLR-9161
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9161.patch
>
>
> The code currently assumes that there is only one setter (or if there are several setters
then the first one found is used and it could mismatch on the arg type).
> Context and motivation is that a class with a
> {code}
> void setAFloat(float val) {
>   this.val = val;
> }
> {code}
> setter may wish to also provide a
> {code}
> void setAFloat(String val) {
>   this.val = Float.parseFloat(val);
> }
> {code}
> convenience setter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message