lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martijn van Groningen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7307) Add getters to PointInSetQuery and PointRangeQuery classes
Date Thu, 02 Jun 2016 07:33:59 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311882#comment-15311882
] 

Martijn van Groningen commented on LUCENE-7307:
-----------------------------------------------

bq. I think the byte[] version was better since it is consitent with PointPangeQuery which
exposes the low/high bounds as a byte[]?

Good point. I'll change that.

bq. Also I don't think it is true that the sortedPackedPoints iterator makes a copy: looking
at PrefixCodedTerms, it seems to be reusing the same BytesRef object?

True... we need to make a copy. I guess what I was confused with is the copy that PrefixCodedTerms
makes from the input, but if it is reusing the BytesRef it copies into then a copy is required
if we return the points in a collection.

bq. Something else we should do is throwing a NoSuchElementException in the Iterator whin
upTo==size to comply with the Iterator API.

+1!

> Add getters to PointInSetQuery and PointRangeQuery classes
> ----------------------------------------------------------
>
>                 Key: LUCENE-7307
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7307
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>            Priority: Trivial
>         Attachments: LUCENE_7307.patch, LUCENE_7307.patch, LUCENE_7307.patch, LUCENE_7307.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message