lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9227) Solr Suggester should report full error when it fails to build
Date Mon, 20 Jun 2016 13:32:05 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339485#comment-15339485
] 

David Smiley commented on SOLR-9227:
------------------------------------

+1 we've all lost time at some point in the past due to badly written error handling that
for forgets to propagate the exception.  This particular bug pattern is a pet peeve of mine.
 With some work in FindBugs or something, a detector could be written; but we don't use FB,
alas.

> Solr Suggester should report full error when it fails to build
> --------------------------------------------------------------
>
>                 Key: SOLR-9227
>                 URL: https://issues.apache.org/jira/browse/SOLR-9227
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Varun Thacker
>
> When building a suggester if it fails, the current logging is not too helpful.
> It would report an error like {{Store Lookup build failed}} but no root cause. 
> This is because of this logging statement in SolrSuggester.java -
> {code}
> LOG.error("Store Lookup build failed");
> {code}
> We should audit logging and fix the places where we don't print the stack track along




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message