lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gethin James (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9237) DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter can't be overidden
Date Sun, 26 Jun 2016 18:06:52 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350193#comment-15350193
] 

Gethin James commented on SOLR-9237:
------------------------------------

I am currently on vacation but, from memory, I believe I just need a constructor to pass in
the 2 objects to create a new Fvhcontainer.  I don't need to access the fields after.

> DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter can't be overidden
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-9237
>                 URL: https://issues.apache.org/jira/browse/SOLR-9237
>             Project: Solr
>          Issue Type: Bug
>          Components: highlighter
>    Affects Versions: 6.1
>            Reporter: Gethin James
>            Assignee: Jan H√łydahl
>             Fix For: 6.1.1, 6.2, master (7.0)
>
>         Attachments: SOLR-9237.patch
>
>
> With *6.1.0* the *protected* method DefaultSolrHighlighter.doHighlightingByFastVectorHighlighter
passes in a *private* class called FvhContainer which makes it very difficult to extend.
> I have code that extends DefaultSolrHighlighter which I can't fix due to this issue.
> Could you consider making FvhContainer  "protected" and use a constructor?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message