lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Varun Thacker (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-9242) Collection level backup/restore should provide a param for specifying the repository implementation it should use
Date Mon, 04 Jul 2016 18:05:11 GMT

     [ https://issues.apache.org/jira/browse/SOLR-9242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Varun Thacker updated SOLR-9242:
--------------------------------
    Attachment: SOLR-9242.patch

Thanks Hrishikesh for the patch!

I've attached a new patch with some minor changes listed below. Let me know how it looks.

OverseerCollectionMessageHandler
1. In processBackupAction remove unused variable propertiesPath
2. In processBackupAction/processRestoreAction remove the "location" checks. Error handling
and validation has ready been done at the CollectionsHandler
3. In processRestoreAction removed unused variable backupZkPath

CoreContainer
1. One minor formatting change

BackupManager
1. Remove unused import


CollectionsHandler
1. Used LOCATION contant at a couple of missing places.


AbstractCloudBackupRestoreTestCase

1. In {{testInvalidPath}} where we set cluster property , added asset that the property has
been set successfully

TestHdfsCloudBackupRestore

1. This prop {{solr.hdfs.confdir}} in the solr.xml file never seemed to be getting used? I
removed it and the tests pass. Do we need this?

CollectionAdminRequest

1. Changed {{setRepository(Optional<String> repository)}} to {{setRepository(String
repository}} . Seems cleaner from an API perspective given it's a setter.
2. Changed the variable name from {{repository}} to {{repositoryName}}
3. Made necessary changes to AbstractCloudBackupRestoreTestCase to fix the compile errors
because of the first two changes.

ReplicationHandler

1. Minor Formatting Changes

TestBackupRepositoryFactory

1. Reverted the change of using the "location" string VS constant. If by change the constant
name, Strings in tests will help us catch it.

> Collection level backup/restore should provide a param for specifying the repository
implementation it should use
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9242
>                 URL: https://issues.apache.org/jira/browse/SOLR-9242
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hrishikesh Gadre
>            Assignee: Varun Thacker
>         Attachments: SOLR-9242.patch, SOLR-9242.patch, SOLR-9242.patch, SOLR-9242.patch
>
>
> SOLR-7374 provides BackupRepository interface to enable storing Solr index data to a
configured file-system (e.g. HDFS, local file-system etc.). This JIRA is to track the work
required to extend this functionality at the collection level.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message