lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael McCandless <luc...@mikemccandless.com>
Subject Re: lucene-solr:master: LUCENE-7581: don't allow updating a doc values field if it's used in the index sort
Date Fri, 09 Dec 2016 23:30:40 GMT
Thanks Uwe, I'll fix.

Mike McCandless

http://blog.mikemccandless.com


On Fri, Dec 9, 2016 at 6:25 PM, Uwe Schindler <uwe@thetaphi.de> wrote:
> Hi,
>
>> +    this.indexSortFields = Arrays.stream(sort.getSort()).map((s) ->
>> s.getField()).collect(Collectors.toSet());
>
> I'd use method references instead of Lambdas:
>
> Instead of: map((s) -> s.getField())
> Use: map(s::getField)
>
> This spares a synthetic lambda$xxx method that clutters stack trace and is more readable.
>
> Uwe
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message