lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Commented] (SOLR-9839) Use 'useFactory' in tests instead of setting manually
Date Wed, 07 Dec 2016 23:45:58 GMT


Erick Erickson commented on SOLR-9839:

There's also the SystemPropertiesRestoreRule that can be used so you don't have to remember
to undo system properties.

useFactory still looks like a good idea, just mentioning the Rule bit for completeness.

> Use 'useFactory' in tests instead of setting manually
> -----------------------------------------------------
>                 Key: SOLR-9839
>                 URL:
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: Mike Drob
>            Priority: Minor
>         Attachments: SOLR-9839.patch
> We have several tests that will explicitly set a directory factory via SysProp, some
of which forget to unset it.
> We should use {{useFactory}} so that we can benefit from the call to {{resetFactory}}
in {{SolrTestCaseJ4.teardownTestCases}}.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message