lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Potter (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6237) An option to have only leaders write and replicas read when using a shared file system with SolrCloud.
Date Thu, 26 Jan 2017 15:00:33 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Timothy Potter updated SOLR-6237:
---------------------------------
    Attachment: SOLR-6237.patch

I'm curious where this issue is headed and would like to help out if we still think it is
doable? I attempted to update the patch to master but still many test failures.

If we want to keep working on this, can you create PR Mark so we can work on the changes in
github vs. with patch files? I'm happy to create one as well ...

Lastly, here are the few changes that I couldn't figure out how to apply from the unified
patch ... mostly related to sliceCount=0 in tests ... unf. I haven't kept up with test refactoring
so am not sure of the correct changes here?

{code}
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java.rej
***************
*** 149,155 ****
  
    
    public CollectionsAPIDistributedZkTest() {
-     sliceCount = 2;
    }
    
    @Override
--- 149,155 ----
  
    
    public CollectionsAPIDistributedZkTest() {
+     sliceCount = 0;
    }
    
    @Override
***************
*** 668,674 ****
          createNodeList.remove(replica.getNodeName());
        }
      }
-     assertEquals(createNodeList.toString(), 1, createNodeList.size());
  
    }
  
--- 668,674 ----
          createNodeList.remove(replica.getNodeName());
        }
      }
+     assertEquals(createNodeList.toString(), 0, createNodeList.size());
  
    }
  
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/CollectionStateFormat2Test.java.rej
***************
*** 28,33 ****
  
  public class CollectionStateFormat2Test extends AbstractFullDistribZkTestBase {
  
    protected String getSolrXml() {
      return "solr-no-core.xml";
    }
--- 28,37 ----
  
  public class CollectionStateFormat2Test extends AbstractFullDistribZkTestBase {
  
+   public CollectionStateFormat2Test() {
+     sliceCount = 0;
+   }
+   
    protected String getSolrXml() {
      return "solr-no-core.xml";
    }
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/CustomCollectionTest.java.rej
***************
*** 73,79 ****
  
  
    public CustomCollectionTest() {
-     sliceCount = 2;
    }
  
    @Override
--- 73,79 ----
  
  
    public CustomCollectionTest() {
+     sliceCount = 0;
    }
  
    @Override
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/DeleteLastCustomShardedReplicaTest.java.rej
***************
*** 55,61 ****
    }
  
    public DeleteLastCustomShardedReplicaTest() {
-     sliceCount = 2;
    }
  
    @Test
--- 55,61 ----
    }
  
    public DeleteLastCustomShardedReplicaTest() {
+     sliceCount = 0;
    }
  
    @Test
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java.rej
***************
*** 61,67 ****
    }
  
    public DeleteReplicaTest() {
-     sliceCount = 2;
    }
  
    @Test
--- 61,67 ----
    }
  
    public DeleteReplicaTest() {
+     sliceCount = 0;
    }
  
    @Test
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java.rej
***************
*** 62,69 ****
    }
  
    public OverseerRolesTest() {
-     sliceCount = 2;
-     fixShardCount(TEST_NIGHTLY ? 6 : 2);
    }
  
    @Test
--- 62,69 ----
    }
  
    public OverseerRolesTest() {
+     sliceCount = 0;
+     fixShardCount(TEST_NIGHTLY ? 6 : 3);
    }
  
    @Test
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/RecoveryZkTest.java.rej
***************
*** 114,120 ****
  
      // test that leader and replica have same doc count
      
-     String fail = checkShardConsistency("shard1", false, false);
      if (fail != null) {
        fail(fail);
      }
--- 114,120 ----
  
      // test that leader and replica have same doc count
      
+     String fail = checkShardConsistency(DEFAULT_COLLECTION, "shard1", false, false);
      if (fail != null) {
        fail(fail);
      }
[master] ~/dev/lw/projects/lucene-solr$ cat ./solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverTest.java.rej
***************
*** 95,101 ****
  
    
    public SharedFSAutoReplicaFailoverTest() {
-     sliceCount = 2;
      completionService = new ExecutorCompletionService<>(executor);
      pending = new HashSet<>();
    }
--- 95,101 ----
  
    
    public SharedFSAutoReplicaFailoverTest() {
+     sliceCount = 0;
      completionService = new ExecutorCompletionService<>(executor);
      pending = new HashSet<>();
    }
{code}

> An option to have only leaders write and replicas read when using a shared file system
with SolrCloud.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-6237
>                 URL: https://issues.apache.org/jira/browse/SOLR-6237
>             Project: Solr
>          Issue Type: New Feature
>          Components: hdfs, SolrCloud
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>         Attachments: 0001-unified.patch, SOLR-6237.patch, Unified Replication Design.pdf
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message