lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <>
Subject [jira] [Updated] (SOLR-9877) Use instrumented http client
Date Tue, 03 Jan 2017 20:08:58 GMT


Shalin Shekhar Mangar updated SOLR-9877:
    Attachment: SOLR-9877_branch_6x.patch

Here's a patch that applies on branch_6x. It required a different approach than master because
6.x uses an older deprecated http client API. I ended up extending DefaultHttpClient to override
the createRequestExecutor() method which creates and sets up the InstrumentedHttpRequestExecutor.

This does not use the HttpClientFactory and its methods introduced in SOLR-6625 but firstly
the factory's static setter is never used in Solr and secondly, I'll open an issue to get
rid of it completely.

> Use instrumented http client
> ----------------------------
>                 Key: SOLR-9877
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>         Attachments: SOLR-9877.patch, SOLR-9877.patch, SOLR-9877_branch_6x.patch, solr-http-metrics.png
> Use instrumented equivalents of PooledHttpClientConnectionManager and others from metrics-httpclient

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message