lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Woodward (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-7609) Refactor expressions module to use DoubleValuesSource
Date Thu, 05 Jan 2017 10:52:58 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alan Woodward updated LUCENE-7609:
----------------------------------
    Attachment: LUCENE-7609.patch

Updated patch:
* Removes the queries/ValueSource dependency entirely - I had thought that we could keep this
backwards-compatible, but there's a breaking change in the Bindings public signature, so we
may as well go all in.
* Removes the ValueSource.asDoubleValuesSource() helper method - will put this in separately
with LUCENE-7610 as it's no longer tested by exercising the expressions
* Changes subsources to return 0 if they have no value.  I tried making this configurable
but couldn't find a nice way of doing it - something for a later ticket maybe.

> Refactor expressions module to use DoubleValuesSource
> -----------------------------------------------------
>
>                 Key: LUCENE-7609
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7609
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>         Attachments: LUCENE-7609.patch, LUCENE-7609.patch
>
>
> With DoubleValuesSource in core, we can refactor the expressions module to use these
instead of ValueSource, and remove the dependency of expressions on the queries module in
master.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message