lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-9921) Separate SolrMetricProducer from SolrInfoMBean
Date Wed, 04 Jan 2017 08:30:59 GMT

    [ https://issues.apache.org/jira/browse/SOLR-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15797588#comment-15797588
] 

Andrzej Bialecki  commented on SOLR-9921:
-----------------------------------------

Also, {{SolrMetricProducer.initializeMetrics}} currently returns {{Collection<String>}}
with names of the registered metrics. This was originally intended as a way to ensure that
at least some metrics were actually registered by a producer. However, in practice this is
not that useful, and there are producers that can't know in advance what metrics they will
register throughout the life-cycle of a component. For these reasons I'm planning to change
this method so that it doesn't return anything.

> Separate SolrMetricProducer from SolrInfoMBean
> ----------------------------------------------
>
>                 Key: SOLR-9921
>                 URL: https://issues.apache.org/jira/browse/SOLR-9921
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: master (7.0), 6.4
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>            Priority: Minor
>             Fix For: master (7.0), 6.4
>
>
> {{SolrMetricProducer}} currently extends {{SolrInfoMBean}} but in most cases this is
not needed, and then additional methods inherited from {{SolrInfoMBean}} don't make much sense.
This issue is about separating these two interfaces.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message