lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7623) Add FunctionScoreQuery and FunctionMatchQuery
Date Wed, 11 Jan 2017 04:08:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817100#comment-15817100
] 

David Smiley commented on LUCENE-7623:
--------------------------------------

Looks alright but I didn't review thoroughly. I noticed one problem: {{TwoPhaseIterator.matchCost}}
as implemented here isn't right.  It's supposed to be the match cost for a _single document_,
thus returning maxDocs is definitely not the right response.  See the javadocs.  Unfortunately
since DoubleValueSource has no similar cost, you can't propagate... so might as well return
some constant.  Judging from existing impls... anywhere between 10 and 100 is good to me.

> Add FunctionScoreQuery and FunctionMatchQuery
> ---------------------------------------------
>
>                 Key: LUCENE-7623
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7623
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-7623.patch, LUCENE-7623.patch
>
>
> We should update the various function scoring queries to use the new DoubleValues API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message