lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ishan Chattopadhyaya (JIRA)" <>
Subject [jira] [Updated] (SOLR-10011) Refactor PointField & TrieField to share common code
Date Sat, 21 Jan 2017 00:59:26 GMT


Ishan Chattopadhyaya updated SOLR-10011:
    Attachment: SOLR-10011.patch

Here's a stab at refactoring, by introducing a new common base class NumericFieldType.

The tests pass after this refactoring. [~tomasflobbe], can you please review?

bq. That would help this refactor, but may need to be master-only
I think the refactoring in this patch is backwards compatible. Had an offline discussion with
[~hossman], who suggested that such an approach (introducing a new base class on top of TrieField)
is backwards compatible.

> Refactor PointField & TrieField to share common code
> ----------------------------------------------------
>                 Key: SOLR-10011
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>         Attachments: SOLR-10011.patch, SOLR-10011.patch, SOLR-10011.patch
> We should eliminate PointTypes and TrieTypes enum to have a common enum for both. That
would enable us to share a lot of code between the two field types.
> In the process, fix the bug:
> PointFields with indexed=false, docValues=true seem to be using (Int|Double|Float|Long)Point.newRangeQuery()
for performing exact matches and range queries. However, they should instead be using DocValues
based range query.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message