lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dawid Weiss <dawid.we...@gmail.com>
Subject Re: [VOTE] Release Lucene/Solr 6.4.1 RC1
Date Thu, 02 Feb 2017 08:43:10 GMT
I see what this is -- Andrzej added another test to this test class
and the test that fails relied on test ordering (and the number of
calls to the api):

    // The stats bean for SolrInfoMBeanHandler
    NamedList stats =
(NamedList)diff.get("ADMIN").get("/admin/mbeans").get("stats");

    //System.out.println("stats:"+stats);
    assertEquals("Was: 1, Now: 2, Delta: 1", stats.get("requests"));

Because another test calls the API the result is now:

Was: [4, Now: 5], Delta: 1

which makes sense. I don't think this is a showstopper for the release
and an easy fix too.

Dawid



On Thu, Feb 2, 2017 at 9:39 AM, Dawid Weiss <dawid.weiss@gmail.com> wrote:
> Could be related to changes in SOLR-9947 made by Andrzej, but no idea,
> to be honest.
>
> Dawid
>
> On Thu, Feb 2, 2017 at 9:26 AM, Adrien Grand <jpountz@gmail.com> wrote:
>> Thanks Dawid for reporting this error, I agree we should look into it. I am
>> not familiar with this test either, can someone who is familiar with this
>> test comment about whether this is worth respinning?
>>
>> Le jeu. 2 févr. 2017 à 09:18, Dawid Weiss <dawid.weiss@gmail.com> a écrit
:
>>>
>>> It's the same failure. Don't know whether this should be a release
>>> blocker qualified for respin; perhaps yes?
>>>
>>> Dawid
>>>
>>> On Wed, Feb 1, 2017 at 11:20 PM, Kevin Risden <compuwizard123@gmail.com>
>>> wrote:
>>> > https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Linux/2780/
>>> >
>>> > Looks like the same failure is happening on Jenkins.
>>> >
>>> > Kevin Risden
>>> >
>>> > On Wed, Feb 1, 2017 at 4:27 PM, Dawid Weiss <dawid.weiss@gmail.com>
>>> > wrote:
>>> >>
>>> >> This test failed for me during the first smoketester run:
>>> >>
>>> >>    [junit4] FAILURE 0.05s J1 | MBeansHandlerTest.testDiff <<<
>>> >>    [junit4]    > Throwable #1: org.junit.ComparisonFailure:
>>> >> expected:<Was: [1, Now: 2], Delta: 1> but was:<Was: [4, Now:
5],
>>> >> Delta: 1>
>>> >>    [junit4]    >        at
>>> >>
>>> >> __randomizedtesting.SeedInfo.seed([8B5954CB0E2B8501:4E4F90501E9DBD61]:0)
>>> >>    [junit4]    >        at
>>> >>
>>> >>
>>> >> org.apache.solr.handler.admin.MBeansHandlerTest.testDiff(MBeansHandlerTest.java:63)
>>> >>
>>> >> Repro line (didn't try): ant test  -Dtestcase=MBeansHandlerTest
>>> >> -Dtests.method=testDiff -Dtest
>>> >> s.seed=8B5954CB0E2B8501 -Dtests.locale=th -Dtests.timezone=US/Arizona
>>> >> -Dtests.asserts=true -Dtests.file.enco
>>> >> ding=UTF-8
>>> >>
>>> >> The second time it was ok, so could be something intermittent.
>>> >>
>>> >> SUCCESS! [0:58:03.206234]
>>> >>
>>> >> Dawid
>>> >>
>>> >> ---------------------------------------------------------------------
>>> >> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> >> For additional commands, e-mail: dev-help@lucene.apache.org
>>> >>
>>> >
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message