lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-6246) Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
Date Tue, 07 Feb 2017 19:10:41 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856580#comment-15856580
] 

Steve Rowe edited comment on SOLR-6246 at 2/7/17 7:09 PM:
----------------------------------------------------------

bq. I was confused too! I recommend marking this as fixed for 6.4.1 and 6.5.0 [...]  I think
adjusting the fix version is more true to the title of this issue being addressed at the 6.4.1
version.

I think you're right - I added 6.4.1 as fix version.  I'm leery of introducing an intentional
difference between JIRA and CHANGES, but really the issue is that there should have been a
*Solr* CHANGES note for the Lucene changes, but I didn't do that. 


was (Author: steve_rowe):
bq. I was confused too! I recommend marking this as fixed for 6.4.1 and 6.5.0 [...]  I think
adjusting the fix version is more true to the title of this issue being addressed at the 6.4.1
version.

I think you're right - I added 6.4.1 as fix version.  I'm leery of introducing an intentional
difference in CHANGES, but really the issue is that there should have been a *Solr* CHANGES
note for the Lucene changes, but I didn't do that. 

> Core fails to reload when AnalyzingInfixSuggester is used as a Suggester
> ------------------------------------------------------------------------
>
>                 Key: SOLR-6246
>                 URL: https://issues.apache.org/jira/browse/SOLR-6246
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SearchComponents - other
>    Affects Versions: 4.8, 4.8.1, 4.9, 5.0, 5.1, 5.2, 5.3, 5.4
>            Reporter: Varun Thacker
>            Assignee: Steve Rowe
>             Fix For: 6.4.1, 6.5, master (7.0)
>
>         Attachments: SOLR-6246.patch, SOLR-6246.patch, SOLR-6246-test.patch, SOLR-6246-test.patch,
SOLR-6246-test.patch, SOLR-6246-test.patch
>
>
> LUCENE-5477 - added near-real-time suggest building to AnalyzingInfixSuggester. One of
the changes that went in was a writer is persisted now to support real time updates via the
add() and update() methods.
> When we call Solr's reload command, a new instance of AnalyzingInfixSuggester is created.
When trying to create a new writer on the same Directory a lock cannot be obtained and Solr
fails to reload the core.
> Also when AnalyzingInfixLookupFactory throws a RuntimeException we should pass along
the original message.
> I am not sure what should be the approach to fix it. Should we have a reloadHook where
we close the writer?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message