lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7673) Add MultiValued[Int/Long/Float/Double]FieldSource for SortedNumericDocValues
Date Mon, 06 Feb 2017 17:58:42 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854455#comment-15854455
] 

Tomás Fernández Löbbe commented on LUCENE-7673:
-----------------------------------------------

Thanks for the review David!
bq.  It'd be nice if {{DoubleValueSource}} and {{LongValueSource}}...
Maybe we can add them later if needed? It looks like {{DoubleValueSource}} and {{LongValueSource}}
instances can be obtained with {{ValueSource#asDoubleValuesSource()}} and {{ValueSource#asLongValuesSource()}},
is there anything else you'd add? Maybe the helper methods {{DoubleValuesSource.fromMultiValuedDoubleField(...)}}?

> Add MultiValued[Int/Long/Float/Double]FieldSource for SortedNumericDocValues
> ----------------------------------------------------------------------------
>
>                 Key: LUCENE-7673
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7673
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Tomás Fernández Löbbe
>         Attachments: LUCENE-7673.patch
>
>
> Right now \[Int/Long/Float/Double\]FieldSource can give a {{ValueSource}} view of a {{NumericDocValues}}
field. This Jira is to add MultiValued\[Int/Long/Float/Double\]FieldSource that given a {{SortedNumericSelector.Type}}
can give a {{ValueSource}} view of a {{SortedNumericDocValues}} field
> I considered instead of adding new classes an optional selector parameter to the existing
\[Int/Long/Float/Double\]FieldSource, but I think adding different classes makes a cleaner
API and it’s clear that for MultiValued* case, the selector is a mandatory parameter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message