lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-10141) Caffeine cache causes BlockCache corruption
Date Wed, 15 Feb 2017 16:45:41 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15868132#comment-15868132
] 

Yonik Seeley edited comment on SOLR-10141 at 2/15/17 4:45 PM:
--------------------------------------------------------------

Adding a guard in the test code is easy enough (just check if "live" has already been set
to false), but that then uncovers an additional problem: a memory leak since size() != (adds-removes)
at the end (i.e. the removal listener is not called for all items).

It looks like the removal listener is called the correct number of times, but not always with
the correct value.  My guess is that it's somehow related to concurrent use of equal keys
with different values.


was (Author: yseeley@gmail.com):
Adding a guard in the test code is easy enough (just check if "live" has already been set
to false), but that then causes an additional problem: a memory leak since size() != (adds-removes)
at the end (i.e. the removal listener is not called for all items).

It looks like the removal listener is called the correct number of times, but not always with
the correct value.  My guess is that it's somehow related to concurrent use of equal keys
with different values.

> Caffeine cache causes BlockCache corruption 
> --------------------------------------------
>
>                 Key: SOLR-10141
>                 URL: https://issues.apache.org/jira/browse/SOLR-10141
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Yonik Seeley
>         Attachments: SOLR-10141.patch
>
>
> After fixing the race conditions in the BlockCache itself (SOLR-10121), the concurrency
test passes with the previous implementation using ConcurrentLinkedHashMap and fail with Caffeine.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message