lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jitka18 <...@git.apache.org>
Subject [GitHub] lucene-solr issue #189: Jira/solr 6203
Date Wed, 19 Apr 2017 21:08:02 GMT
Github user jitka18 commented on the issue:

    https://github.com/apache/lucene-solr/pull/189
  
    Hi, Christine.  I accepted your pull request and will update my branch from
    the  master later today.   Will also take a look at the tests in DQCCST.
    
    Thanks,
    Judith
    
    On Wed, Apr 19, 2017 at 1:19 PM, Christine Poerschke <
    notifications@github.com> wrote:
    
    > Hi Judith - thanks for adding me to the collaborator list. I've added one
    > more commit to the jitka18#1
    > <https://github.com/jitka18/lucene-solr/pull/1> request and would suggest
    > something along the following lines as the next steps:
    >
    >    - to review jitka18#1 <https://github.com/jitka18/lucene-solr/pull/1>
    >    and if it looks good merge it into your jira/solr-6203 branch and/or add
    >    comments on the pull request
    >    - to merge the latest master (at the time) into the jira/solr-6203
    >    working branch
    >    ** this will give some merge conflicts that need to be resolved
    >    ** this will somewhat reduce the scope and complexity of the changes
    >    for the working branch since SOLR-10394 part-2 renames will be picked up
    >    from the latest master
    >    - to see if new code duplication in DistributedQueryComponentCustomSortTest
    >    can be reduced further, this will not just reduce the amount of code but
    >    will (i think) also help with clarity i.e. what is being tested
    >
    > How does that sound? Any questions, please let me know. - Christine
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/lucene-solr/pull/189#issuecomment-295423545>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AZdiss7MqSiBLhVpl4Bb7Ud__PZTDCe1ks5rxmxhgaJpZM4M-ruZ>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message