lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-7756) Only record the major that was used to create the index rather than the full version
Date Sun, 02 Apr 2017 19:43:41 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952827#comment-15952827
] 

Michael McCandless commented on LUCENE-7756:
--------------------------------------------

bq. However for testing old codecs, we create new indices (createdVersion = 7) with old codec
components that do not support recording the minVersion, such as Lucene62RWSegmentInfoFormat

Ahh, OK, and that is because our "fake creating of old indices" isn't perfect (sets createdVersion
= 7).  OK, this makes sense, and is hard to think about.  Thanks.

> Only record the major that was used to create the index rather than the full version
> ------------------------------------------------------------------------------------
>
>                 Key: LUCENE-7756
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7756
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-7756.patch, LUCENE-7756.patch
>
>
> LUCENE-7703 added information about the Lucene version that was used to create the index
to the segment infos. But since there is a single creation version, it means we need to reject
calls to addIndexes that can mix indices that have different creation versions, which might
be seen as an important regression by some users. So I have been thinking about only recording
the major version that was used to create the index, which is still very valuable information
and would allow us to accept calls to addIndexes when all merged indices have the same major
version. This looks like a better trade-off to me.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message