lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10394) search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
Date Wed, 19 Apr 2017 21:08:41 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975525#comment-15975525
] 

ASF GitHub Bot commented on SOLR-10394:
---------------------------------------

Github user jitka18 commented on the issue:

    https://github.com/apache/lucene-solr/pull/189
  
    Hi, Christine.  I accepted your pull request and will update my branch from
    the  master later today.   Will also take a look at the tests in DQCCST.
    
    Thanks,
    Judith
    
    On Wed, Apr 19, 2017 at 1:19 PM, Christine Poerschke <
    notifications@github.com> wrote:
    
    > Hi Judith - thanks for adding me to the collaborator list. I've added one
    > more commit to the jitka18#1
    > <https://github.com/jitka18/lucene-solr/pull/1> request and would suggest
    > something along the following lines as the next steps:
    >
    >    - to review jitka18#1 <https://github.com/jitka18/lucene-solr/pull/1>
    >    and if it looks good merge it into your jira/solr-6203 branch and/or add
    >    comments on the pull request
    >    - to merge the latest master (at the time) into the jira/solr-6203
    >    working branch
    >    ** this will give some merge conflicts that need to be resolved
    >    ** this will somewhat reduce the scope and complexity of the changes
    >    for the working branch since SOLR-10394 part-2 renames will be picked up
    >    from the latest master
    >    - to see if new code duplication in DistributedQueryComponentCustomSortTest
    >    can be reduced further, this will not just reduce the amount of code but
    >    will (i think) also help with clarity i.e. what is being tested
    >
    > How does that sound? Any questions, please let me know. - Christine
    >
    > —
    > You are receiving this because you authored the thread.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/lucene-solr/pull/189#issuecomment-295423545>,
    > or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AZdiss7MqSiBLhVpl4Bb7Ud__PZTDCe1ks5rxmxhgaJpZM4M-ruZ>
    > .
    >



> search.grouping.Command rename: getSortWithinGroup --> getWithinGroupSort
> -------------------------------------------------------------------------
>
>                 Key: SOLR-10394
>                 URL: https://issues.apache.org/jira/browse/SOLR-10394
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>             Fix For: 6.6, master (7.0)
>
>         Attachments: SOLR-10394-part2.patch, SOLR-10394.patch
>
>
> The class is marked _@lucene.experimental_ and SOLR-9660 previously included sortSpecWithinGroup
to withinGroupSortSpec renaming for GroupSpecification; the rename proposed here is in line
with that.
> Motivation for the change is to reduce group-sort vs. within-group-sort confusion, generally
and specifically in SOLR-6203.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message