lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christine Poerschke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-10414) RecoveryStrategy should be Runnable and not a Thread
Date Tue, 04 Apr 2017 13:46:41 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955150#comment-15955150
] 

Christine Poerschke commented on SOLR-10414:
--------------------------------------------

SOLR-6885 added the {{setName("RecoveryThread-"+this.coreName);}} that is being removed here
and I'd be curious as to whether or not logging from different cores in the same JVM would
still be distinguishable without it. I think it would be, via the {{MDCLoggingContext}} stuff
added later under SOLR-7590.

So +1 for RecoveryStrategy not being a Thread then.

> RecoveryStrategy should be Runnable and not a Thread
> ----------------------------------------------------
>
>                 Key: SOLR-10414
>                 URL: https://issues.apache.org/jira/browse/SOLR-10414
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>         Attachments: SOLR-10414.patch
>
>
> {{RecoveryStrategy}} is currently a {{Thread}} but is never started, it's just used as
a {{Runnable}} and submitted to Executors. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message