lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrzej Bialecki (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-10418) metrics should return JVM system properties
Date Wed, 12 Apr 2017 22:05:41 GMT

     [ https://issues.apache.org/jira/browse/SOLR-10418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Andrzej Bialecki  updated SOLR-10418:
-------------------------------------
    Attachment: SOLR-10418.patch

Updated patch that allows to select one of properties of {{MetricsMap}}-s. This significantly
complicates the code in MetricUtils, and it adds confusing behavior to metric filters:

* it sort of breaks the contract of PrefixFilter because now it needs to match also possible
matches on {{MetricsMap}} property names that we don't know yet at the time of filter evaluation.
This can be worked around by creating a separate implementation of MetricFilter just for the
use in MetricsHandler.

* RegexFilter doesn't work this way at all, ie. it's not possible to select fully-qualified
nested properties using "regex" param. The reason is that in order to evaluate regexes against
full property names the actual values from {{MetricsMap.getValue()}} need to be retrieved
in order to build the full names. This may be costly, eg. if we iterate a cache, and in some
cases this may also have side-effects (eg. HDFS {{Metrics}} resets incremental stats on each
call).

This patch doesn't support yet the property exclusion list.

> metrics should return JVM system properties
> -------------------------------------------
>
>                 Key: SOLR-10418
>                 URL: https://issues.apache.org/jira/browse/SOLR-10418
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Noble Paul
>            Assignee: Andrzej Bialecki 
>         Attachments: SOLR-10418.patch, SOLR-10418.patch
>
>
> We need to stop using the custom solution used in rules and start using metrics for everything



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message