lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Høydahl (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-10587) Ban defaultSearchField in schema for luceneMatchVersion =>6.6.0
Date Sun, 30 Apr 2017 23:05:04 GMT

    [ https://issues.apache.org/jira/browse/SOLR-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15990498#comment-15990498
] 

Jan Høydahl commented on SOLR-10587:
------------------------------------

Thanks for contributing. Comments:
* We should keep the *WARNING* about deprecation, the one you changed from WARN to INFO
* {{bad-schema-defaultsearchfield.xml}} can be much smaller, e.g.
{code:xml}
<schema name="bad-schema-defaultsearchfield" version="1.6">
  <fieldType name="string" class="solr.StrField"/>
  <field name="id" type="string" indexed="true" stored="true" multiValued="false" required="false"/>
  <uniqueKey>id</uniqueKey>
  <!-- BEGIN BAD STUFF: not allowed anymore -->
  <defaultSearchField>id</defaultSearchField>
  <!-- END BAD STUFF -->
</schema>
{code}

Would you like to submit an updated patch?

Wrt converting existing tests into using "df" I think we can use SOLR-7041 for that and commit
same to both master and branch_6x. I think we should just do a series of smaller commits until
all tests are converted, and once that is done this one can be committed.

> Ban defaultSearchField in schema for luceneMatchVersion =>6.6.0
> ---------------------------------------------------------------
>
>                 Key: SOLR-10587
>                 URL: https://issues.apache.org/jira/browse/SOLR-10587
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Schema and Analysis
>            Reporter: Jan Høydahl
>             Fix For: 6.6
>
>         Attachments: SOLR-10587.patch
>
>
> Sub task of SOLR-7041.
> For new configs with luceneMatchVersion >=6.6.0 we'll throw an exception if  defaultSearchField
is used in schema.
> For luceneMatchVersion < 6.0.0 we'll behave like before (warn only). This is to deliver
on our back-compat promise between minor versions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message