lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Gerlowski (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-9321) Removed usage of deprecated clusterstate.getSlicesMap(), getSlices() and getActiveSlices()
Date Fri, 02 Jun 2017 05:41:04 GMT

     [ https://issues.apache.org/jira/browse/SOLR-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Gerlowski updated SOLR-9321:
----------------------------------
    Attachment: SOLR-9321.patch

Updated patch removes the usage of all deprecated methods from {{ClusterState}}, with the
exception of {{getZkClusterStateVersion}}.  All tests pass locally.

{{getZkClusterStateVersion}} has no successor in the {{DocCollection}} class, so removing
the few places it is used is a less obvious swap.  Since the method is used to determine whether
the ClusterState has changed since some access/read, my first hunch is that ClusterState.hashCode
might be a suitable replacement for determining this.

ClusterState.hashCode bases the hash largely off of the ZK-node-version.  Since getZkClusterStateVersion
was deprecated out of concerns for its use of Zk-node-version, it doesn't really seem in the
spirit of the deprecation replace calls with ClusterState.hashCode.  At least as hashCode
is written now.

Do you have any advice/suggestions/opinions on what we can replace those getZkClusterStateVersion
calls with?

> Removed usage of deprecated clusterstate.getSlicesMap(), getSlices() and getActiveSlices()
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-9321
>                 URL: https://issues.apache.org/jira/browse/SOLR-9321
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: 7.0
>
>         Attachments: SOLR-9321.patch, SOLR-9321.patch, SOLR-9321.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message