lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6671) Introduce a solr.data.home as root dir for all data
Date Sun, 02 Jul 2017 22:15:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16071804#comment-16071804
] 

Uwe Schindler commented on SOLR-6671:
-------------------------------------

I'd do it that way:

{code:java}
private void assertDataHome(String expected, String instanceDir, RAMDirectoryFactory rdf,
MockCoreContainer cc, String... properties) throws IOException {
  String dataHome = rdf.getDataHome(new CoreDescriptor("core_name", Paths.get(instanceDir),
cc.containerProperties, cc.isZooKeeperAware(), properties));
  assertEquals(Paths.get(expected).toAbsolutePath(), Paths.get(dataHome).toAbsolutePath());
}
{code}

I just tested and passes also on windows! I can commit that if you like!

> Introduce a solr.data.home as root dir for all data
> ---------------------------------------------------
>
>                 Key: SOLR-6671
>                 URL: https://issues.apache.org/jira/browse/SOLR-6671
>             Project: Solr
>          Issue Type: New Feature
>          Components: SolrCloud
>    Affects Versions: 4.10.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>             Fix For: master (7.0)
>
>         Attachments: SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch,
SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch, SOLR-6671.patch
>
>
> Many users prefer to deploy code, config and data on separate disk locations, so the
default of placing the indexes under {{$\{solr.solr.home\}/$\{solr.core.name\}/data}} is not
always wanted.
> In a multi-core/collection system, there is not much help in the {{solr.data.dir}} option,
as it would set the {{dataDir}} to the same folder for all collections. One workaround, if
you don't want to hardcode paths in your {{solrconfig.xml}}, is to specify the {{dataDir}}
property in each {{solr.properties}} file.
> A more elegant solution would be to introduce a new Java-option {{solr.data.home}} which
would be to data the same as {{solr.solr.home}} is for config. If set, all collections would
default their {{dataDir}} as {{$\{solr.data.home\)/$\{solr.core.name\}/data}}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message