lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class
Date Wed, 05 Jul 2017 18:48:00 GMT


ASF subversion and git services commented on SOLR-11004:

Commit 30e9b51af71161d2e775ec438e0d14295537cf34 in lucene-solr's branch refs/heads/master
from [~anshumg]
[;h=30e9b51 ]

SOLR-11004: Consolidate SolrClient builder code into an abstract base class to reduce duplication.

> Consolidate SolrClient Builder code in abstract parent class
> ------------------------------------------------------------
>                 Key: SOLR-11004
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>    Affects Versions: master (8.0)
>            Reporter: Jason Gerlowski
>            Priority: Minor
>             Fix For: master (8.0)
>         Attachments: SOLR-11004.patch, SOLR-11004.patch
> As [~anshumg] pointed out in SOLR-10456, the Builder code for each SolrClient has a lot
of duplication in it.
> For example, each SolrClient allows configuration of the connection timeout: all 4 builders
have a field to store this value, all 4 builders have a {{withConnectionTimeout}} method to
set this value, and all 4 builders have very similar Javadocs documenting what this value
can be used for.
> The same can be said for 5 or 6 other properties common to most/all SolrClient's.
> This duplication could be removed by creating an abstract SolrClientBuilder class, which
each of the specific Builders extend.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message