lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-11004) Consolidate SolrClient Builder code in abstract parent class
Date Wed, 05 Jul 2017 19:07:00 GMT

    [ https://issues.apache.org/jira/browse/SOLR-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075255#comment-16075255
] 

ASF subversion and git services commented on SOLR-11004:
--------------------------------------------------------

Commit 454950aae6bb155ded2085d13fea062654b5af28 in lucene-solr's branch refs/heads/branch_7x
from [~anshumg]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=454950a ]

SOLR-11004: Consolidate SolrClient builder code into an abstract base class to reduce duplication.


> Consolidate SolrClient Builder code in abstract parent class
> ------------------------------------------------------------
>
>                 Key: SOLR-11004
>                 URL: https://issues.apache.org/jira/browse/SOLR-11004
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: SolrJ
>            Reporter: Jason Gerlowski
>            Assignee: Anshum Gupta
>            Priority: Minor
>             Fix For: 7.0, master (8.0)
>
>         Attachments: SOLR-11004.patch, SOLR-11004.patch
>
>
> As [~anshumg] pointed out in SOLR-10456, the Builder code for each SolrClient has a lot
of duplication in it.
> For example, each SolrClient allows configuration of the connection timeout: all 4 builders
have a field to store this value, all 4 builders have a {{withConnectionTimeout}} method to
set this value, and all 4 builders have very similar Javadocs documenting what this value
can be used for.
> The same can be said for 5 or 6 other properties common to most/all SolrClient's.
> This duplication could be removed by creating an abstract SolrClientBuilder class, which
each of the specific Builders extend.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message